Add skipLibCheck so we stop checking node_modules package definitions #3707
Conversation
|
How does this differ from #3668? |
strictNullChecks is a safety feature; generally you'd want to keep that if you can because it reduces the risk of various errors. As I've always understood it, all of the strictness rules are important but one issue is how they apply to any typings you have downloaded. After all, you might not be able to trust that every dependency followed the same compilation rules. The only situation where you could if you had a pretty strong control over all of your dependencies. Generally though, on most projects you don't; you're getting dependencies from all over. skipLibCheck allows you to opt libraries out of the these strictness rules while making sure all of your code meets that standard. Generally, that's how projects I've worked on are configured. |
|
Do you want to sync this branch so we can test it with the other fixes included? |
wwahammy
force-pushed
the
correct-the-lib-check
branch
from
fcab3ed
to
2abc6e2
Compare
|
@ocdtrekkie ts-check passes now 🥳 |
|
Closing this one, as I merged 3708 into the |
skipLibCheck skips checking type declaration files. This should fix typescript type checking in the build